[x264-devel] [PATCH] add support for FreeBSD in common/cpu.c

Igor Mozolevsky igor at hybrid-lab.co.uk
Mon Jan 14 10:07:59 CET 2008


On 04/01/2008, Guillaume POIRIER <poirierg at gmail.com> wrote:
> > > On Dec 30, 2007 10:59 PM, Igor Mozolevsky <igor at hybrid-lab.co.uk> wrote:
> > > > --- common/cpu.c.orig   2007-12-30 21:40:50.000000000 +0000
> > > > +++ common/cpu.c        2007-12-30 21:44:20.000000000 +0000
> > > > @@ -28,7 +28,7 @@
> > > >  #ifdef SYS_BEOS
> > > >  #include <kernel/OS.h>
> > > >  #endif
> > > > -#ifdef SYS_MACOSX
> > > > +#if defined(SYS_MACOSX) || defined(__FreeBSD__)
> > >
> > > __FreeBSD__ is not defined by the configure script, which may harm
> > > cross-compiling, or using compilers different from GCC.
> > > The right way to do it, I believe, is to use SYS_FREEBSD instead.
> > >
> > > Please try attached patch, which is more correct IMHO.
> >
> > Fair point, I prefer to fix the real problem and let people in the
> > know figure the fix into the whole system, otherwise it takes way too
> > much time.
>
> Ok, but you didn't confirm if the new patch worked for you or not...

The patch works fine :-) Sorry I took ages to get back!

Cheers,
Igor



More information about the x264-devel mailing list