[x264-devel] [PATCH] Hack for svnversion equivalent on git

[Pierre d'Herbemont]

On Mar 7, 2008, at 6:47 PM, Jason Martens wrote:

>
> On Mar 7, 2008, at 11:33 AM, Pierre d'Herbemont wrote:
>
>> You only have to tag one commit to have git describe working, not
>> all... That's seem to be a bit much ;)
>
> Remember, it's a hack for an svnversion equivalent; most people refer
> to a build of x264 by the number that svnversion reports.  If you tag
> only one commit, versioning for higher commits breaks down.
>
> For example:
>
> git-tag -m "git-746" git-746 233a760dc99fe8a6cc401b711ffb3a3c90f8a5fa
>
> But build from the current HEAD, which svnversion would report as 748:
>
> #define X264_VERSION "git-746-2-g397d1bf"
> #define X264_POINTVER "0.58.git-746-2-g397d1bf"

Note that you get git-746-2, which means 2 commits after 746. You can  
moreover check that the commit you have is the write one corresponding  
to g397d1bf. This is basically the same as refering to a number for  
the commit.

And if you choose to tag the 0.58 release you end up with an even  
nicer v0.58-XX-XXXXX working version number. (release_number- 
incr_dev_number-commit_id)

I really think that's overkill to tag every single commit. You'll have  
to change a bit how downstream work, but that can be such a bad idea.

Pierre.