[x264-devel] [PATCH] Fix shared libs on MacOSX

[İsmail Dönmez]

Hi,

On Fri, Mar 28, 2008 at 11:21 AM, Gregor Riepl <seto-kun at freesurf.ch> wrote:
> > I have used gcc-4.2 from XCode 3.1 beta which worked fine.
>
>  unfortunately, this is no solution if you want to build x264 for a pre-
>  leopard osx.
>  afaik, the bug lies in gcc indeed, and i think it's been known for
>  some time.
>  if i remember correctly, some xine developer has written a workaround
>  to a similar problem. i'll try to look it up.
>
>  thanks for your patch, i found a little bug in it though:
>      echo "SONAME=libx264.$SOEXT.$API" >> config.mak
>
>  this works for elf based systems, but for mach-o, the version is
>  usually in front of .dylib, not after.
>  the patch should say (for example):
>       API=$(grep '#define X264_BUILD' < x264.h | cut -f 3 -d ' ')
>  -    echo "SONAME=libx264.so.$API" >> config.mak
>  +    if [ $SYS = MACOSX ]; then
>  +        SOEXT="dylib"
>  +        echo "SONAME=libx264.$API.$SOEXT" >> config.mak
>  +    else
>  +        SOEXT="so"
>  +        echo "SONAME=libx264.$SOEXT.$API" >> config.mak
>  +    fi
>  +    echo "SOEXT=$SOEXT" >> config.mak

Thanks for catching that, updated patch attached.

Regards,
ismail

-- 
Never learn by your mistakes, if you do you may never dare to try again.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: x264-osx-shared-v3.patch
Type: application/octet-stream
Size: 1972 bytes
Desc: not available
Url : http://mailman.videolan.org/pipermail/x264-devel/attachments/20080329/fd1713fe/attachment.obj