[x264-devel] [PATCH] Fix shared libs on MacOSX

[Guillaume POIRIER]

Hello,

On Fri, Mar 28, 2008 at 11:44 PM, İsmail Dönmez <ismail at namtrac.org> wrote:
> Hi,
>
>  2008/3/28 alex gao <madfxgao at gmail.com>:
>
> >  After using your patch v1 or v2, with --enable-shared option and Xcode
>  >  3.1 beta1, I still meet error:
>  >
>  >
>  >  ld warning: option -s is obsolete and being ignored
>  >  ld: absolute addressing (perhaps -mdynamic-no-pic) used in
>  >  _x264_cabac_encode_decision from common/x86/cabac-a.o not allowed in
>  >  slidable image. Use '-read_only_relocs suppress' to enable text relocs
>  >  collect2: ld returned 1 exit status
>  >  make: *** [libx264.dylib.58] Error 1
>  >
>  >  So I add option -read_only_relocs suppress to gcc, and it works fine
>
>  Can you try ./configure --enable-shared --host=x86_64-apple-darwin9 ,
>  maybe its 32bit related as I can't reproduce it with my 64bit build.

On my Tiger Macintel machine, this allows to build PIC, shared, and
PIC+shared kinds in 64 bits mode.
It however doesn't work in 32 bits mode.

Can your confirm 32 bits mode also doesn't compile on your machine İsmail?

Apart from that, the patch looks very clean to me. I'm tempted to
apply it unless Loren objects...

Guillaume
-- 
A soldier will fight long and hard for a bit of colored ribbon.
 -- Napoleon Bonaparte