[x264-devel] [PATCH] Fix shared libs on MacOSX

[Alexander Strange]

On Mar 29, 2008, at 3:35 PM, Guillaume POIRIER wrote:
>
>>> ld: common symbols not allowed with MH_DYLIB output format with the
>>> -multi_module option
>>> common/dct.o definition of common _x264_dct4_weight2_zigzag (size  
>>> 128)
>>> common/dct.o definition of common _x264_dct8_weight2_zigzag (size  
>>> 512)
>>> encoder/analyse.o definition of common _x264_cost_mv_fpel (size 832)
>>> /usr/libexec/gcc/i686-apple-darwin8/4.0.1/libtool: internal link  
>>> edit
>>> command failed
>>> make: *** [libx264.58.dylib] Error 1
>>>
>>> I googled a bit and it seems like this is a GCC bug, but I'm not  
>>> sure.
>>>
>>> İsmail, do you have a idea of how to fix this problem?
>>
>> Does the attached patch fixes this for you?
>
> yep, it does, but it's strange that such a fix is necessary. It's the
> compiler not doing its job...

You have to use -fno-common to avoid generating these. (or -Wl,- 
single_module, which is supposedly slightly more efficient, though I  
don't know how it works)