[x264-devel] fix x264_macroblock_analyse and x264_mb_analyse_p_rd functions

[Gabriel Bouvigne]

Noboru Asai a écrit :

> (2) patch-fix-x264_mb_analyse_p_rd-1
> 
> Callgraph of x264_rd_cost_mb function is
> 
> x264_rd_cost_mb
>   -> x264_macroblock_size_cabac (x264_macroblock_write_cabac)
>      -> x264_cabac_mb8x8_mvd
>         -> x264_cabac_mb_mvd
>            -> x264_mb_predict_mv
> 
> Since h->mb.i_partition is referenced in x264_mb_predict_mv function,
> it should be "D_8x8" before calling x264_rd_cost_mb function.

I tryed this patch on 6 testcases, in 2 passes mode with AQ disabled.

*in all cases, I noticed a very tiny bitrate reduction (less than 0.5%)
*in all cases, the number of p8x8 blocks was significantly increased (by 
30-50%)
*in most of the cases, there was a slight increase of both psnr and ssim
*visually, the difference is small enough to not be significant

By comparing x264_mb_analyse_p_rd and x264_mb_analyse_b_rd, it seems to 
me that this patch is correct.

--
Gabriel