[x264-devel] 2 proposals for configure script about assembler check

[Surf Chen]

On Tue, May 20, 2008 at 12:11 PM, Loren Merritt <lorenm at u.washington.edu> wrote:
> On Mon, 19 May 2008, Surf Chen wrote:
>
>> 1st :
>> NASM_BUILD=`nasm -v|grep "Apple Computer"|sed 's/.*build \([0-9]*\).*/\1/'`
>> if [ $NASM_BUILD -lt $NASM_BUILD_REQUIRED ]
>>
>> It works if we are using the nasm produced by Apple.But when we
>> download nasm from sf.net and compile it by ourself,the script will
>> fail since here nasm -v would output "NASM version 2.02 compiled on
>> May 19 2008",but not 'NASM version 0.98.40 (Apple Computer, Inc. build
>> 11) compiled on Sep 23 2007'.
>
> We don't need to check nasm version, we check features instead (ability
> to compile SSSE3). yasm version needs checking because certain yasm
> versions silently miscompile some code.
>
Your meaning is the nasm version checking in configure script should
be removed,right?

>> 2nd:
>> If the yasm not exists,there will be a msg output to stderr.I use the
>> below patch(produced with git diff) to fix it.
>
> You can redirect stderr without adding any temporary variables.
Thanks. Sorry about that temp var.I just wanted to point it out clearly.

>
> --Loren Merritt
> _______________________________________________
> x264-devel mailing list
> x264-devel at videolan.org
> http://mailman.videolan.org/listinfo/x264-devel
>