[x264-devel] [PATCH] disable PIC in C code on Darwin

[Alexander Strange]

On Oct 1, 2008, at 9:13 AM, Guillaume POIRIER wrote:

> Hello,
>
> 2008/9/29 Alexander Strange <astrange at ithinksw.com>:
>> This fixes a major speed loss on Darwin vs. other systems and  
>> shouldn't
>> affect building shared libraries.
>
> It appears to me that it does affect the build of shared libs:
>
> common/mc.c:0: warning: -mdynamic-no-pic overrides -fpic or -fPIC
> common/predict.c:0: warning: -mdynamic-no-pic overrides -fpic or -fPIC
> common/pixel.c:0: warning: -mdynamic-no-pic overrides -fpic or -fPIC
> common/macroblock.c:0: warning: -mdynamic-no-pic overrides -fpic or - 
> fPIC
> common/frame.c:0: warning: -mdynamic-no-pic overrides -fpic or -fPIC
> common/dct.c:0: warning: -mdynamic-no-pic overrides -fpic or -fPIC
> [...]

Sorry, I'd forgotten it overrides other flags.
Could someone test this one on OS X 10.4+i386?
I know it works on 10.5, but I think shared libraries with dynamic-no- 
pic are a feature of the new ld.

This also makes configure assume Apple GCC a bit more, which isn't  
really important; I could write a check_cflags and fix some other  
lines if someone wants it.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-fix-darwin-speed-regression.patch
Type: text/x-diff
Size: 636 bytes
Desc: not available
Url : http://mailman.videolan.org/pipermail/x264-devel/attachments/20081002/fcba701e/attachment.patch 
-------------- next part --------------