[x264-devel] [PATCH] disable PIC in C code on Darwin

[Guillaume POIRIER]

Hello,

On Thu, Oct 2, 2008 at 11:51 PM, Guillaume POIRIER <poirierg at gmail.com> wrote:
> Hello,
>
> 2008/10/2 Alexander Strange <astrange at ithinksw.com>:
>> On Oct 1, 2008, at 9:13 AM, Guillaume POIRIER wrote:
>>> 2008/9/29 Alexander Strange <astrange at ithinksw.com>:
>>>>
>>>> This fixes a major speed loss on Darwin vs. other systems and shouldn't
>>>> affect building shared libraries.
>>>
>>> It appears to me that it does affect the build of shared libs:
>>>
>>> common/mc.c:0: warning: -mdynamic-no-pic overrides -fpic or -fPIC
>>> common/predict.c:0: warning: -mdynamic-no-pic overrides -fpic or -fPIC
>>> common/pixel.c:0: warning: -mdynamic-no-pic overrides -fpic or -fPIC
>>> common/macroblock.c:0: warning: -mdynamic-no-pic overrides -fpic or -fPIC
>>> common/frame.c:0: warning: -mdynamic-no-pic overrides -fpic or -fPIC
>>> common/dct.c:0: warning: -mdynamic-no-pic overrides -fpic or -fPIC
>>> [...]
>>
>> Sorry, I'd forgotten it overrides other flags.
>> Could someone test this one on OS X 10.4+i386?
>
> Has anyone tested this? superdump?

Tested on 10.4.11/PPC, and it works. I'm gonna apply your patch over
the weekend unless someone disagrees.

Guillaume
-- 
One should not give up hope on imbeciles. With a little training, you
can make them into soldiers.
 -- Pierre Desproges