[x264-devel] crash in latest version

[David Sullivan]

Hi guys,
I found something interesting.
The option under investigation is subme.
Executing the simple call x264 c:\mobile_cif.y4m --bitrate 100 -subme 8 -o
mobile.mkv
x264 (r999) code crashes.
It appens even when subme equals to 9.

For lower values it works fine.

I read the changelog of Tue Sep 30 18:34:56 2008 (r996)
and I saw that darkshikari reworked subme system.
Any suggestions?

Anyway I'll test r995 tomorrow.

Txn
David

2008/10/21 Gabriel Bouvigne <gabriel.bouvigne at joost.com>

> David Sullivan a écrit :
>
>> It crashes with the patch applied with the following parameters.
>> c:\mobile_cif.y4m --pass 1 --bitrate 100 --stats "mobile.stats" --ref 8
>> --mixed-refs --bframes 3
>> --b-adapt 2 --b-pyramid --weightb --direct auto --filter -1:-1 --subme 8
>> --trellis 2 --partitions p8x8,b8x8,i4x4,i8x8 --8x8dct
>> --me umh --threads auto --thread-input --progress --no-psnr --no-ssim -o
>> c:\mob.mkv
>>
>
> It might be related to the reworked weighted predictions from this commit:
>
> http://git.videolan.org/?p=x264.git;a=commitdiff;h=e21b11f4ae99ef8ec0e37c1605f72ef18adfa7c3
>
> In this case, either removing --weightb or applying this new patch would
> solve it. (you should apply both this wpred patch and the already posted
>  hadamard patch)
>
> If that does not work, then the most efficient thing to do would be to
> check from which revision x264 started to crash. (which I can't do easily on
> my side as my computer is a Core and not a Core2)
>
> --
> Gabriel
>
> diff --git a/common/x86/mc-c.c b/common/x86/mc-c.c
> index 1af512b..ca4a127 100644
> --- a/common/x86/mc-c.c
> +++ b/common/x86/mc-c.c
> @@ -310,14 +310,17 @@ void x264_mc_init_mmx( int cpu, x264_mc_functions_t
> *pf )
>     if( !(cpu&X264_CPU_SSSE3) )
>         return;
>
> -    pf->avg[PIXEL_16x16] = x264_pixel_avg_16x16_ssse3;
> -    pf->avg[PIXEL_16x8]  = x264_pixel_avg_16x8_ssse3;
> -    pf->avg[PIXEL_8x16]  = x264_pixel_avg_8x16_ssse3;
> -    pf->avg[PIXEL_8x8]   = x264_pixel_avg_8x8_ssse3;
> -    pf->avg[PIXEL_8x4]   = x264_pixel_avg_8x4_ssse3;
> -    pf->avg[PIXEL_4x8]   = x264_pixel_avg_4x8_ssse3;
> -    pf->avg[PIXEL_4x4]   = x264_pixel_avg_4x4_ssse3;
> -    pf->avg[PIXEL_4x2]   = x264_pixel_avg_4x2_ssse3;
> +    if (!(cpu&X264_CPU_STACK_MOD4))
> +    {
> +        pf->avg[PIXEL_16x16] = x264_pixel_avg_16x16_ssse3;
> +        pf->avg[PIXEL_16x8]  = x264_pixel_avg_16x8_ssse3;
> +        pf->avg[PIXEL_8x16]  = x264_pixel_avg_8x16_ssse3;
> +        pf->avg[PIXEL_8x8]   = x264_pixel_avg_8x8_ssse3;
> +        pf->avg[PIXEL_8x4]   = x264_pixel_avg_8x4_ssse3;
> +        pf->avg[PIXEL_4x8]   = x264_pixel_avg_4x8_ssse3;
> +        pf->avg[PIXEL_4x4]   = x264_pixel_avg_4x4_ssse3;
> +        pf->avg[PIXEL_4x2]   = x264_pixel_avg_4x2_ssse3;
> +    }
>
>     pf->hpel_filter = x264_hpel_filter_ssse3;
>     pf->frame_init_lowres_core = x264_frame_init_lowres_core_ssse3;
>
> _______________________________________________
> x264-devel mailing list
> x264-devel at videolan.org
> http://mailman.videolan.org/listinfo/x264-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mailman.videolan.org/pipermail/x264-devel/attachments/20081021/79615c87/attachment.htm