[x264-devel] segfault in predict_8x8_ddl_sse2 in shared lib

[Jason Garrett-Glaser]

> Thanks very much for the quick reply. I tried adding that to
> slicetype_decide but the problem remained. However, when I modified
> x264_slicetype_mb_cost the segfault went away (yay!).

I was referring to using that on the entire program (on the top
function, encoder_encode, like Avidemux does).

> I hesitate to try and formulate a patch since I'm unsure if this is
> the preferred fix generally, I don't know under what conditions it
> should be used (shared lib only? 32 bit only? gcc x.y.z only?), and
> what other functions might need the same thing, but if someone more
> expert in the x264 code creates a patch at some point, I'd be more
> than happy to help test it.

We are not going to use that because it requires gcc 4.2; hell, I
don't even use that recent a version of gcc.

The best solution would be to call slicetype_decide the same way
stack_align is called on x264_slice_write in encoder.c.

Dark Shikari