[x264-devel] commit: Correct misprediction of bitrate in threaded mode ( Gabriel Bouvigne )

Jason Garrett-Glaser darkshikari at gmail.com
Tue Sep 16 23:50:02 CEST 2008


2008/9/16 BugMaster <BugMaster at narod.ru>:
> ...

Your patch has other issues, such as:

-                    abr_buffer *= X264_MAX( 1, sqrt(i_frame_done/25) );
+                    abr_buffer *= X264_MAX( 1, sqrt(i_frame_done / rcc->fps) );

This is a completely nonsensical change, since 25 is not the
framerate, its simply a magic number; I see no reason to change it to
the framerate.

Anyways, Gabriel is the prime maintainer of ratecontrol; talk to him about it.

Dark Shikari


More information about the x264-devel mailing list