[x264-devel] commit: Correct misprediction of bitrate in threaded mode ( Gabriel Bouvigne )

[BugMaster]

On Wed, 17 Sep 2008 23:04:58 +0400, BugMaster wrote:
> On Wed, 17 Sep 2008 20:49:41 +0200, Gabriel Bouvigne wrote:
>> BugMaster a écrit :

>>> This patch do diametrically opposed to what my patch do. It only makes
>>> worse. 
>> [...]
>>> "rcc->expected_bits_sum" also
>>> show the expected size of frames which ended encode (because it
>>> calculated in "x264_ratecontrol_end").

>> You are right, I overlooked the fact that expected_bits_sum only 
>> includes finished frames.

>> Then why not just using something like this one?
>> Instead of extrapolating the size of frames being encoded and adding it
>> to total_bits, it simply compares total_bits against 
rcc->>>expected_bits_sum, which both only include finished frames.


>> --
>> Gabriel


> This must be OK. I simply think that "rce.expected_bits" used there
> for some reason (as I understand it differs from "rcc->expected_bits_sum"
> even for the same number of frames).

> _______________________________________________
> x264-devel mailing list
> x264-devel at videolan.org
> http://mailman.videolan.org/listinfo/x264-devel

After some test I think that using of "rce.expected_bits" in this
calculation gives more precise hit in to choosen bitrate than when
using "rcc->expected_bits_sum".