[x264-devel] [PATCH] OS/2 support + '--with-install' option

[KO Myung-Hun]

Hi/2.

Loren Merritt wrote:
> On Sat, 27 Sep 2008, KO Myung-Hun wrote:
>
>   
>> '--with-install' option to use a
>> install program other than 'install', such as 'ginstall'.
>>     
>
> Use a shell variable, not a cli option. Then it's just one line:
> INSTALL=${INSTALL-install}
>
>   

Ok.

>> + ULONG numprocs = 1;
>>     
>
> Either uint32_t or unsigned long. I don't care what the OS/2 API docs say, 
> ULONG isn't a standard type.
>
>   

uint32_t, Ok.

>> + ; Kludge: aout format does not support .rodata neither align, so use .data.
>>     
>
> Then you can't use SSE. Unless you mean that all sections are always 
> 16-byte aligned, and only the attribute is missing?
>
>   

Does it mean crash or disablement of SSE feature ?

I know, all sections of aout are not 16-bytes aligned, and aout accept 
only .text, .data, and .bss without any extension such as align.

Ah, I'm using nasm. So I am not sure that this is true for yasm.

Nevertheless, I have not received any responses related to SSE problem 
by OS/2 users.

If align problem is confirmed, I would try to submit another patch, 
using OMF not aout.

>> + echo "IMPLIBNAME=libx264_dll.a" >> config.mak
>>     
>
> MINGW uses IMPLIBNAME=libx264.dll.a
> Are you stuck in 8.3 land?
>   

It already has 11 chars in name part. ^^

kLIBC( gcc port for OS/2 ) recognizes '_dll.a' as a import lib.

Finally, I have a question.

Is tools/avc2avi.c maintained ?

ld complain about undefined bs_xxx symbols.

And if so, I'll submit another patch for it.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 1.1.11
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 1 GHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: os2.diff
Url: http://mailman.videolan.org/pipermail/x264-devel/attachments/20080928/63075542/attachment.txt