[x264-devel] x264_encoder_open name change

[Jason Garrett-Glaser]

On Sun, Dec 27, 2009 at 7:16 PM,  <galmar at cox.net> wrote:
> In the latest versions of x264.h the following lines occur:
>
> #define x264_encoder_glue2(x,y) x264_encoder_glue1(x,y)
> #define x264_encoder_open x264_encoder_glue2(x264_encoder_open_,X264_BUILD)
>
> This causes the x264_encoder_open function to be compiled as x264_encoder_open_80 which causes
> problems latter on when attempting to configure ffmpeg.  Why was this change made?

There are no problems that occur during ffmpeg configuration.  ffmpeg
configure checks for encoder_encode, not encoder_open.

If you read the commit log, you would see that the reason the change
was made was to eliminate a massive class of bad bug reports caused by
users inadvertently compiling ffmpeg against a version of x264
different than the one they linked against, resulting in unpredictable
crashes and brokenness caused by an API  mismatch.

Dark Shikari