[x264-devel] Solaris 10 sparc patch to configure

[Loren Merritt]

On Fri, 23 Jan 2009, Robinson, Greg wrote:

> And finally, the version.sh script does not work on my system as I do not
> have git installed.  And if I did, it would not work.

Git has been ported, so the only possible meaning or your sentence I can 
see is that `sort`, `join`, `awk`, and all the other standard tools used 
in version.sh also broken on Solaris?

> Could I suggest a wrapper script for the detection of git and if not, then a
> grep for the variables X264_VERSION and X264_BUILD so they can be placed in
> config.h.  Otherwise, they are not present and the build fails.

The wrapper script already detects git. X264_BUILD is in x264.h, and 
doesn't depend on git.

If you don't have the git repository, then X264_VERSION isn't present 
anywhere, and a wrapper wouldn't help.
If you have the .git directory (via tarball), but not the git software, 
then I'm sure not going to implement a sufficient subset of git to extract 
the info. It's not just in some text file.
If someone wants to give the videolan guys a modified tarball-generation 
script which hardcodes the version number into the non-git case in 
version.sh, ok.

> --- configure.orig      Fri Jan 23 11:27:08 2009
> +++ configure   Fri Jan 23 11:26:47 2009
> @@ -73,7 +73,15 @@
> # check whether 'echo -n' works as expected, otherwise try printf
> if [ "x`echo -n houba`" = xhouba ]
> then
> -  ECHON="echo -n"
> +# determine a good echo
> +  case `uname -s` in
> +  'SunOS')
> +       ECHON="/usr/ucb/echo -n"
> +       ;;
> +  *)
> +       ECHON="echo -n"
> +       ;;
> +   esac
> elif [ "x`printf houba`" = xhouba ]
> then
>   ECHON="printf"

The code you add is *inside a check for whether echo -n works*. How 
exactly can that "if" pass if echo is broken?
Or is echo so broken that it parses -n as an option but just doesn't *do* it?

> @@ -311,7 +319,7 @@
>         exit 1
>     fi
> else
> -    AS=""
> +    AS="$AS"
> fi

breaks --disable-asm
Also, that line is a nop.

--Loren Merritt