[x264-devel] commit: add AltiVec implementation of x264_pixel_var_16x16 and x264_pixel_var_8x8 (Guillaume Poirier )

[Jason Garrett-Glaser]

On Sun, Jan 25, 2009 at 3:07 PM, Guillaume POIRIER
<gpoirier at mplayerhq.hu> wrote:
> Hello,
>
> On Sun, Jan 25, 2009 at 11:47 PM, Jason Garrett-Glaser
> <darkshikari at gmail.com> wrote:
>
>> Um... that patch doesn't have any effect on the chroma planes.  You're
>> changing pic_alloc, when you should be changing x264_frame_new.
>> Furthermore, you're trying to align the chroma planes, but you're not
>> aligning their stride.  You have to change:
>>
>> frame->i_stride[i] = i_stride >> !!i;
>>
>> to
>>
>> frame->i_stride[i] = ALIGN( i_stride >> !!i, 16);
>
> Are you sure? This leads to a beautiful segfault here:

You also need to replace luma_plane_size/4 with chroma_plane_size
accordingly (make a new variable).

Dark Shikari