[x264-devel] Some valgrind warnings on uninitialized variables in me.c

Jason Garrett-Glaser darkshikari at gmail.com
Wed Mar 4 06:45:24 CET 2009


On Tue, Mar 3, 2009 at 9:39 PM, Mathieu Monnier <manao at melix.net> wrote:
>> Well, you know, except for the part where they are?
>>
>> #define DIA1_ITER( mx, my )\
>> {\
>>    omx = mx; omy = my;\
>>    COST_MV_X4( 0,-1, 0,1, -1,0, 1,0 );\
>> }
>
> That in itself doesn't prove anything. Valgrind wouldn't report an error
> here if mx or my weren't initialized, but will report an error when a
> conditionnal jump is done using those uninitialized values.

Then the appropriate response is to find which value is actually the
problem where, not to blindly report valgrind error after valgrind
error without actually analyzing to see if there is a real problem.

Dark Shikari


More information about the x264-devel mailing list