[x264-devel] Yet another updated threaded slicetype patch (v14)

[Mike Kazmier]

On Thu, Apr 16, 2009 at 11:35 AM "Steven Walters" <kemuri9 at gmail.com> wrote:
>>
> > No, the v14 patch runs perfectly on linux.
> >
> > --DaKaZ
> >
> 
> that made me suspicious so i compiled it in my gcc 4.3.3 (x64) and
> without the fix it silently closes without tossing out a complaint
> (but).
> it took the previous mentioned fix to have
> 
> ./x264.exe --lookahead 10 --b-adapt 2 -b16 --crf 18 -o NUL
> ../foreman_cif_352x288.yuv --me tesa -m9 --pass 1 --threads 4 -v 2>
> verbose.txt
> 
> result in
> 
> x264 [info]: slice I:2     Avg QP:18.33  size: 30960  PSNR Mean
> Y:43.80 U:46.40 V:47.92 Avg:44.65 Global:44.28
> x264 [info]: slice P:128   Avg QP:20.78  size:  6730  PSNR Mean
> Y:40.60 U:43.92 V:46.01 Avg:41.61 Global:41.42
> x264 [info]: slice B:170   Avg QP:23.92  size:  1915  PSNR Mean
> Y:38.70 U:42.96 V:45.18 Avg:39.85 Global:39.69
> 
> which seems to be the proper consensus among properly working versions.
> 
> looks like i'll have to find/make an x86 version of mingw 4.3.3 and
> confirm it works there and see if it's a failure of gcc 3.4.x...

Steven, all windows users: I really want to get this patch into the main GIT repository so that other work can begin on items like lookahead VBV and b-adapt 2 threading.  Is the consensus that this patch (with Steven's) works properly?  if so, I will incorporate the two ASAP and get them submitted for inclusion.

--DaKaZ