[x264-devel] [Patch][RFC] moving presets, tunings, profiles from x264.c to common.c

[Jason Garrett-Glaser]

On Tue, Nov 10, 2009 at 2:25 AM, aviad rozenhek <aviadr1 at gmail.com> wrote:
> as $subj, mainly to allow users of libx264 to use presets, without having to
> maintain their own presets in their application.
>
> --
> Aviad Rozenhek
>
> _______________________________________________
> x264-devel mailing list
> x264-devel at videolan.org
> http://mailman.videolan.org/listinfo/x264-devel
>
>

The problem is that this changes the way the presets work.  Currently:

preset is applied

tune is applied

all other settings are applied

profile is applied

Your method makes them applied in commandline order, which may confuse
some users (especially with regard to --profile).  It would make more
sense, IMO, to have param_default() take a preset and tuning as an
argument, for example.

Dark Shikari