[x264-devel] commit: Fix all aliasing violations (Jason Garrett-Glaser )

git version control git at videolan.org
Thu Nov 12 21:30:36 CET 2009


x264 | branch: master | Jason Garrett-Glaser <darkshikari at gmail.com> | Thu Nov 12 05:25:32 2009 -0800| [47270c2c6e4b96b76d3a4ece5e3cb757aa0917bf] | committer: Jason Garrett-Glaser 

Fix all aliasing violations
New type-punning macros perform write/read-combining without aliasing violations per the second-to-last part of 6.5.7 in the C99 specification.
GCC 4.4, however, doesn't seem to have read this part of the spec and still warns about the violations.
Regardless, it seems to fix all known aliasing miscompilations, so perhaps the GCC warning generator is just broken.
As such, add -Wno-strict-aliasing to CFLAGS.

> http://git.videolan.org/gitweb.cgi/x264.git/?a=commit;h=47270c2c6e4b96b76d3a4ece5e3cb757aa0917bf
---

 common/bs.h            |   10 ++--
 common/common.h        |   15 ++++
 common/dct.c           |   32 ++++----
 common/frame.c         |    8 +-
 common/macroblock.c    |  187 +++++++++++++++++++++++-------------------------
 common/macroblock.h    |   35 +++++----
 common/predict.c       |   97 +++++++++++--------------
 common/quant.c         |    4 +-
 common/x86/predict-c.c |    8 +-
 common/x86/util.h      |    8 +-
 encoder/analyse.c      |   88 +++++++++++-----------
 encoder/macroblock.c   |   47 ++++++------
 encoder/me.c           |   15 +++--
 encoder/slicetype.c    |   16 ++--
 14 files changed, 286 insertions(+), 284 deletions(-)

Diff:   http://git.videolan.org/gitweb.cgi/x264.git/?a=commitdiff;h=47270c2c6e4b96b76d3a4ece5e3cb757aa0917bf


More information about the x264-devel mailing list