[x264-devel] pic_struct / hrd patch

[Alex Giladi]

Attached is the fixed and updated version of the HRD patch.
Trahald was right (thanks!), and the VBV fullness routine was really broken.
Alex.

On Fri, Oct 16, 2009 at 8:45 AM, Trahald <wewk584 at gmail.com> wrote:
> I think your x264_vbv_fullness() routine is broken. initial cpb removal
> delay is holding negative values. it is what is causing elecard to reject
> the stream.
>
> On Mon, Oct 12, 2009 at 10:34 AM, Alex Giladi <alex.giladi at gmail.com> wrote:
>>
>> Anyone that sees a problem with this patch -- can you please provide
>> some details?
>> Thanks!
>> Alex.
>>
>> On Sun, Oct 11, 2009 at 3:31 PM, Jason Garrett-Glaser
>> <darkshikari at gmail.com> wrote:
>> > On Wed, Oct 7, 2009 at 12:03 PM, Alex Giladi <alex.giladi at gmail.com>
>> > wrote:
>> >> Attached is the new version of the HRD patch with several changes due
>> >> to the inputs from Dark_Shikari, Manao and Trahald.
>> >> The two major fixes cpb_removal_delay for IDR frames and calculation
>> >> of initial_cpb_removal_delay.
>> >> Alex.
>> >
>> > From a guy with BD authoring software on Doom9:
>> >
>> >>Elecard and Sonic reject streams [using NAL-HRD pic struct v8 patch]
>> >> completely, while Trahald's work fine up to rev16, because in later rev's
>> >> (19) changed some calculations which crash x264 with GOP 24
>> >
>> > Dark Shikari
>> > _______________________________________________
>> > x264-devel mailing list
>> > x264-devel at videolan.org
>> > http://mailman.videolan.org/listinfo/x264-devel
>> >
>> _______________________________________________
>> x264-devel mailing list
>> x264-devel at videolan.org
>> http://mailman.videolan.org/listinfo/x264-devel
>
>
> _______________________________________________
> x264-devel mailing list
> x264-devel at videolan.org
> http://mailman.videolan.org/listinfo/x264-devel
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: x264-r1342-nal_hrd-pic_struct-v10.patch
Type: application/octet-stream
Size: 35094 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/x264-devel/attachments/20091119/e5432fcb/attachment-0001.obj>