[x264-devel] [PATCH] Relaxed parameter checking at encoder/encoder.c

Marco Aurélio Graciotto Silva magsilva at gmail.com
Sun Dec 12 00:14:06 CET 2010


On Sat, Dec 11, 2010 at 9:00 PM, Jason Garrett-Glaser <jason at x264.com> wrote:
> As I already told you on the ffmpeg thread, this is not a bug; this is
> entirely intentional behavior.  x264 uses the broken defaults of
> ffmpeg to detect when a user has not set a -vpre.  Relaxing these to
> allow users to remove parts of the ffmpeg preset is entirely
> contradictory to the purpose of said code.

So, the preset is not something user's should edit, but rather an
design/development option: instead of hardcoding everything in C,
define a external file and use it. Ok, I got it.

On the other hand, the presets, as they are currently defined, let the user
think that qmin, qmax and friends have any effect in lossless compression,
which is completely misleading, as x264 will override such options...

Regards,

Marco Aurélio


More information about the x264-devel mailing list