[x264-devel] [PATCH] Relaxed parameter checking at encoder/encoder.c

Marco Aurélio Graciotto Silva magsilva at gmail.com
Sun Dec 12 01:48:34 CET 2010


On Sat, Dec 11, 2010 at 9:52 PM, Jason Garrett-Glaser <jason at x264.com> wrote:
>
> In x264 option handling, a "preset" applies before all other options.
> This defines the defaults.  Users are of course free to define options
> that override these defaults.  x264's default preset is "medium".
>
> Unfortunately, because of how ffmpeg works internally, it overrides
> all of x264's defaults with completely broken options.  This
> effectively means the defaults aren't set properly.
>
> Therefore, the user must set a preset with -vpre to fix this.  The
> user is, of course, free to set *other* presets of his own after that.

Jason, thank you for the explanation. Now I understand the issue
more clearly.


> Yes, this system sucks.  Yes, patches are welcome to ffmpeg to improve
> this (that is, patches to use per-codec options to eliminate this
> hackery).

That would be Michael's work you mentioned before (as reply to
Alexander's email)? I will search the mailing list later for further
details.

Regards,

Marco


More information about the x264-devel mailing list