[x264-devel] commit: Warn about shadowed variable declarations (Anton Mitrofanov )

[Jason Garrett-Glaser]

2010/6/9 Håkan Hjort <hakan.hjort at gmail.com>:
> On Wed, Jun 9, 2010 at 18:39,  <git at videolan.org> wrote:
>> x264 | branch: master | Anton Mitrofanov <BugMaster at narod.ru> | Tue Jun  8 02:43:37 2010 +0400| [7372a9890ec46a8b8badf643f2afcb6de1c0592b] | committer: Jason Garrett-Glaser
>>
>> Warn about shadowed variable declarations
>> Also get rid of a few instances of variable shadowing.
>>
> -snip-
>>
>> Diff:   http://git.videolan.org/gitweb.cgi/x264.git/?a=commitdiff;h=7372a9890ec46a8b8badf643f2afcb6de1c0592b
>
> Where these bits in ratecontrol.c discussed / checked for code changes?
> (Since other commits seems to be doing the reverse... caching values
> to not re-read in loops)

They were changed previously because h->sps->i_mb_height is a double
dereference... which it no longer is, so there's much less of a
benefit to doing that.

Dark Shikari