[x264-devel] [PATCH] Fix free of invalid pointer for tune tmp value.

Jason Garrett-Glaser darkshikari at gmail.com
Fri Jun 11 04:38:34 CEST 2010


On Thu, Jun 10, 2010 at 7:13 PM, Evan McClain <evan.mcclain at gatech.edu> wrote:
> The attached x264_tune_film.txt gdb backtrace recently started happening
> on my OpenSUSE facotry workstation with --tune film. The rather trivial
> attached patch fixes the issue for me.
>
> It's probably related to some relatively recent glibc or gcc change
> (bug?), but I don't follow the changes too closely.

I'm pretty sure char is always 8 bits.  The problem is that the malloc
is actually 1 byte too short, because it omits the NULL terminator.
The fix for this is already committed locally.

Jason


More information about the x264-devel mailing list