[x264-devel] [PATCH] Fix build on Solaris 10 SPARC

[Sean McGovern]

On Fri, Nov 19, 2010 at 7:33 PM, Jason Garrett-Glaser <jason at x264.com>wrote:

> On Fri, Nov 19, 2010 at 4:12 PM, Sean McGovern <gseanmcg at gmail.com> wrote:
> > On Sun, Oct 10, 2010 at 7:39 PM, Sean McGovern <gseanmcg at gmail.com>
> wrote:
> >>
> >> On Sun, Oct 10, 2010 at 7:29 PM, Sean McGovern <gseanmcg at gmail.com>
> wrote:
> >>>
> >>> Submitted for approval, here is a patch that fixes build of x264 on
> SPARC
> >>> Solaris 10.
> >>> Some notes about the patch:
> >>>
> >>> As before, this still assumes you have the GNU compiler & toolchain
> >>> (except Sun's assembler), I have successfully built gcc 4.5.1 myself
> for
> >>> SPARC and have been using that. I have not made any attempt to build
> with
> >>> Sun Studio, although I do have it installed.
> >>> On Solaris, neither /usr/xpg4/bin/grep nor /usr/bin/grep are capable of
> >>> handling binary files directly, so I have instead piped the conftest.o
> >>> through /usr/bin/strings, which also works on many other *ix platforms
> >>> including Linux and MacOS X.
> >>> SPARC is an acronym (http://www.sparc.org/standards/SPARCV9.pdf ,
> section
> >>> 0.1) -- all references have been changed to uppercase (there weren't
> many).
> >>> sun4v's are 64-bit capable as well, so catch this in the configure
> >>> script.
> >>>
> >>> Additionally, although it's largely harmless, builders may want to add
> >>> the LARGEFILE arguments to CFLAGS to squelch a warning. My build script
> >>> (bash-syntax) does it thus:
> >>> LFS_CFLAGS=$(getconf LFS_CFLAGS)
> >>> CFLAGS="${CFLAGS} ${LFS_CFLAGS}"
> >>> I would be more than happy to share my build script if anyone wants a
> >>> copy.
> >>> -- Sean McG
> >>
> >> It helps a bunch when the patch is um... actually attached. Yeah.
> >> -- Sean McG
> >
> > Ping?
>
> Patch fails to apply, send an updated git-format-patch please.
>
> Jason
> _______________________________________________
> x264-devel mailing list
> x264-devel at videolan.org
> http://mailman.videolan.org/listinfo/x264-devel
>


Oops! My bad, one of today's commits conflicted... this one should apply
against current HEAD.

-- Sean McG
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x264-devel/attachments/20101119/19f289cf/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-build-on-SPARC-Solaris-10.patch
Type: text/x-patch
Size: 2822 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/x264-devel/attachments/20101119/19f289cf/attachment.bin>