[x264-devel] [PATCH] silence some warnings on ppc

Jason Garrett-Glaser darkshikari at gmail.com
Mon Sep 6 18:39:44 CEST 2010


On Mon, Sep 6, 2010 at 4:32 AM, Guillaume POIRIER <gpoirier at mplayerhq.hu> wrote:
> Hello,
>
> On Sat, Sep 4, 2010 at 11:01 PM, Manuel Rommel <maaanuuu at gmx.net> wrote:
>> Hello,
>> the attached patch updates the Altivec dct and quant functions. At the
>> moment, the prototypes of the C and Altivec functions don’t match since the
>> dct arrays were converted to 1d
>> in http://git.videolan.org/gitweb.cgi/x264.git/?a=commit;h=287641a7c54d525e0eb74925431541ffb5f9471d .
>> My patch changes the prototypes and thus removes some compiler warnings,
>> fixes memory accesses accordingly and removes some casts that should be
>> useless now.
>
> This patch looks OK to me. I haven't test it yet, but I will once I
> have access to my PPC (provided that it doesn't cause any regression).
>
> Is it Ok Jason?
>
> Best regards,
>
> Guillaume

It's been applied locally since I saw it.

Dark Shikari


More information about the x264-devel mailing list