[x264-devel] Bug in X264: Intra-refresh uses non-refreshed pixels

[Jason Garrett-Glaser]

On Mon, Sep 13, 2010 at 9:46 AM, Chris Brien <chris.brien at tandberg.com> wrote:
> When decoding from a GDR recovery point, the stripe of intra macroblocks
> X264 generates as the refresh boundary is supposed to be pristine, using
> only pixel data from the left of the good/bad boundary in order to ensure
> that (prior to deblocking) the pixels to the left of the boundary are all
> known and correct.
>
> I4x4 macroblocks using vertical-left or diagonal-down-left prediction in the
> top-right 4x4 block use the C neighbour pixel. This means that there is a
> dependency on unknown pixels which can propagate down-left through the
> frame, and will not be cleared-up. These modes should be disabled for these
> blocks.

Can you confirm that disabling these modes actually fixes it?  Here's a patch.

Dark Shikari
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test.diff
Type: application/octet-stream
Size: 5217 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/x264-devel/attachments/20100913/21d31ef8/attachment.obj>