[x264-devel] [PATCH] MPEG2 Program Stream output

[Gil Pedersen]

On 23/02/2011, at 19.14, Lorenzo Pallara wrote:

> 	I didn't get any more feedback for the patch since some days, I updated 
> it to the current git, it should have the changes suggested up to now, 
> you can find it in attach.

A few comments:
You use hrd_timing, but this is only output when i_nal_hrd is set, but you don't specifiy this requirement anywhere.

> +        " .pes -> MPEG2 Program Elementary Stream\n"
This is still misleading. ISO13818-1 has a definition of the term "PES Stream" (section 2.1.38) but imposes some additional requirements, namely coding of the ESCR and ES_rate fields. Since you don't code these a more accurate name is: "Raw MPEG-2 Packetized Elementary Stream". I added the "raw" term so people are less likely to mistake the output for an ISO13818-1 compliant "PES Stream".

/Gil