[x264-devel] problem with interlaced encoding + compilation fix patch

Erik Slagter erik at slagter.name
Fri Jun 3 12:39:18 CEST 2011


The problem has been partly solved.

When using x264 instead of ffmpeg AND applying buffer size AND setting 
nal-hrd, the result is as expected. So imho this is a problem in both 
ffmpeg (doesn't set nal hrd and buffer options in the right order) and 
x264 (doesn't warn that --bff --tff don't have the desired effect if 
--nal-hrd isn't used).

Oh, btw this is a q&d hack to make x264 compile to current ffmpeg again.

diff --git a/filters/video/resize.c b/filters/video/resize.c
index e5bdfe6..d968fbd 100644
--- a/filters/video/resize.c
+++ b/filters/video/resize.c
@@ -41,9 +41,28 @@ static int full_check( video_info_t *info, 
x264_param_t *param )
  #if HAVE_SWSCALE
  #undef DECLARE_ALIGNED
  #include <libswscale/swscale.h>
+#include <libavutil/pixdesc.h>

  /* this function is not a part of the swscale API but is defined in 
swscale_internal.h */
-const char *sws_format_name( enum PixelFormat format );
+/* this function has been removed from ffmpeg commit 
e1197b9e1746c03b1d13d816d1569aeaf1b71ecc
+ * commit e1197b9e1746c03b1d13d816d1569aeaf1b71ecc
+ * Author: Stefano Sabatini <stefano.sabatini-lala at poste.it>
+ * Date:   Sun May 29 17:57:40 2011 +0200
+ *
+ *   swscale: remove sws_format_name()
+ *
+ *   Use av_get_pix_fmt_name() instead.
+ */
+
+static const char *sws_format_name(enum PixelFormat format)
+{
+   const char * rv = av_get_pix_fmt_name(format);
+
+   if(rv)
+       return(rv);
+
+   return "Unknown format";
+}

  typedef struct
  {

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5110 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://mailman.videolan.org/pipermail/x264-devel/attachments/20110603/7ea3cac8/attachment.bin>


More information about the x264-devel mailing list