[x264-devel] [PATCH 4/4] detect GNU as and set $ASFLAGS appropriately

[Sean McGovern]

On Monday, October 17, 2011, Loren Merritt <lorenm at u.washington.edu> wrote:
> On Thu, 29 Sep 2011, Sean McGovern wrote:
>
>> ---
>>  configure |   19 +++++++++++++++++--
>>  1 files changed, 17 insertions(+), 2 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 9159eef..28de7d7 100755
>> --- a/configure
>> +++ b/configure
>> @@ -655,6 +655,13 @@ fi
>>  [ $asm = no ] && AS=""
>>  [ "x$AS" = x ] && asm="no" || asm="yes"
>>
>> +# check for GNU as
>> +non_gnu_as="yes"
>
> Boolean variables should be positive.
>
> And this name sounds like it's talking about a GNU vs a non-GNU
> implementation of `as`, when it's really talking about `as` vs `yasm`.
>
>> @@ -912,10 +919,18 @@ fi
>>
>>  if [ "$bit_depth" -gt "8" ]; then
>>      define HIGH_BIT_DEPTH
>> -    ASFLAGS="$ASFLAGS -DHIGH_BIT_DEPTH"
>> +    [ "$non_gnu_as" = "yes" -a "$asm" != "no" ] && \
>> +        ASFLAGS="$ASFLAGS -DHIGH_BIT_DEPTH" || \
>> +        [ "$asm" != "no" ] && ASFLAGS="$ASFLAGS --defsym HIGH_BIT_DEPTH"
>>  fi
>
> `as --defsym HIGH_BIT_DEPTH` breaks here, saying
> "Fatal error: bad defsym; format is --defsym name=value"
> Maybe it works on Solaris, but if so GNU isn't the determining factor.
>
> --Loren Merritt
> _______________________________________________
> x264-devel mailing list
> x264-devel at videolan.org
> http://mailman.videolan.org/listinfo/x264-devel
>

Feel free to do what you like with these patches. I don't have my SPARC
anymore and at least this one is not important for my x86 builds as I do
have yasm built for Solaris.

-- Sean McG.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x264-devel/attachments/20111017/0a4dc01e/attachment.html>