[x264-devel] [Opalvoip-devel] UPD: h264 plugin problem with new x264 encoder

[Alexander Sbitnev]

I check svn journal. Changing

m_encoder.SetMaxRTPFrameSize(std::min(m_maxRTPSize, m_maxNALUSize));

to

m_encoder.SetMaxRTPPayloadSize(std::min(m_maxRTPSize-PluginCodec_RTP_MinHeaderSize, 
m_maxNALUSize));

makes no impact because m_maxRTPSize (1444). Minus RTP header it is 
going to be 1432. So minimum still will be m_maxNALUSize (1400).
Main cause is "rtpSize = 1400;" inside h264_helper.cxx main function. 
And this line was
initially proposed by me (takes me a lot time to realize it probably 
have something to do with me), but value I propose for that workaround 
is just to small. We should increase this constant up to 1412 or even 
1444. It's up to your decision Robert.


16.01.2012 3:42, Robert Jongbloed ?????:
> If you look at what I just checked in, the maximum size of the RTP 
> structure should now be 1412, not 1400. I renamed some variable to 
> make it clear that we are talking about the max PAYLOAD size at every 
> stage.
>
> Have you tried the latest version yet?
>
> --------
> Robert Jongbloed
> Vox Lucida Pty. Ltd.
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x264-devel/attachments/20120116/ac06c839/attachment.html>