[x264-devel] x86inc: switch to amdnops

Jason Garrett-Glaser git at videolan.org
Wed Mar 7 03:20:16 CET 2012


x264 | branch: master | Jason Garrett-Glaser <jason at x264.com> | Wed Feb 22 13:33:36 2012 -0800| [e856755d2a67f45249c24cb51aa38fc4fa192321] | committer: Jason Garrett-Glaser

x86inc: switch to amdnops
Recent AMD CPUs' instruction decoders choke horribly on extremely long nops (i.e. with 4 prefixes).
Won't affect much, since we don't use ALIGN much.

> http://git.videolan.org/gitweb.cgi/x264.git/?a=commit;h=e856755d2a67f45249c24cb51aa38fc4fa192321
---

 common/x86/x86inc.asm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/common/x86/x86inc.asm b/common/x86/x86inc.asm
index 487e170..582cc9c 100644
--- a/common/x86/x86inc.asm
+++ b/common/x86/x86inc.asm
@@ -92,7 +92,7 @@
 %endif
 
 ; Always use long nops (reduces 0x90 spam in disassembly on x86_32)
-CPU intelnop
+CPU amdnop
 
 ; Macros to eliminate most code duplication between x86_32 and x86_64:
 ; Currently this works only for leaf functions which load all their arguments



More information about the x264-devel mailing list