[x264-devel] [PATCH] Add hidden visibility attribute to x264_cabac_range_lps

[Diego Biurrun]

On 04/16/2013 03:16 PM, Rafaël Carré wrote:
> Fix linking to libx264.a on x86_64 Linux, without needing to use -Bsymbolic
> --- a/common/cabac.c
> +++ b/common/cabac.c
> @@ -1240,6 +1240,7 @@ static const int8_t x264_cabac_context_init_PB[3][1024][2] =
>
> +const uint8_t x264_cabac_range_lps[64][4] __attribute__ ((visibility("hidden")));
>   const uint8_t x264_cabac_range_lps[64][4] =

I only see this used inside of cabac.c, so you might make it static 
instead.  That would be much simpler and not require any gcc attributes.

(disclaimer: I don't know the x264 codebase well, there could be tons of 
things I'm overlooking.)

Diego