[x264-devel] [PATCH] QNX support in x264

[Jason Garrett-Glaser]

On Sat, Feb 2, 2013 at 11:23 PM, Mike Gorchak
<mike.gorchak.qnx at gmail.com> wrote:
> Hi Jason!
>
>> >+    !defined(_STDINT_H_INCLUDED) && \
>> Should we add the similar INTTYPES define for consistency here?
>
> QNX has no corresponding INTTYPES macro, only STDINT.
>
>> >+        CFLAGS="$CFLAGS -I\$(SRCPATH)/extras"
>> Why is this needed here, but not on the other systems that don't have
>> getopt?
>
> I've found two places in the confgure script where "extras" path is
> added, one is for mingw/cygwin platform with Intel C Compiler and one
> is for just Intel C Compiler. So I do not know where is the right
> place for this additional path. So I added additional path right after
> "HAVE_GETOPT_LONG 0" definition.
>
>> >+#ifdef __QNXNTO__
>> >+#undef atof
>> >+#endif /* __QNXNTO__ */
>>
>> Undeffing atoi/atof unconditionally should be fine here, I'd imagine.
>> I've actually already worked on a system that needed this to shut up
>> warnings, so I highly approve of this.
>
> I agree.
>
> Thanks!

Committed locally/to my github with minor changes as mentioned here.  Thanks!

Jason