[x264-devel] Bug found in --intra-refresh

[BugMaster]

On Tue, 23 Jul 2013 17:13:45 -0400, Alain Champenois wrote:
> Hi Jason,

> You missed removing I_PRED_4x4_HD mode which also make use of the top-right pixels:

> -        {I_PRED_4x4_H, I_PRED_4x4_HD, I_PRED_4x4_HU, -1, -1, -1, -1, -1},
> +        {I_PRED_4x4_H, I_PRED_4x4_HU, -1, -1, -1, -1, -1},

> With this modification, my qualifications tests are now passing and intra refresh
> properly remove all corruption.

>   Alain
>   PS: After reviewing the code, the top-right restrictions are already only
>       applied for the right-most intra column, so the code is already optimal.
> _______________________________________________
> x264-devel mailing list
> x264-devel at videolan.org
> http://mailman.videolan.org/listinfo/x264-devel

Hi. I_PRED_4x4_HD don't use top-right pixels. It use only left, top
and top-left.

Also fixed version (there were problems with missing initialization of
some used mode_available elements) of patch is here
https://github.com/DarkShikari/x264-devel/commit/fe996190563d000e4d6b3db7974d9c36f91044ec
With this patch it should give bitexact output after intra-refresh
with correct decoder.