[x264-devel] macho64 or macho format: Use .const for read only data instead of .text?

Paul Sterne make4ppc at gmail.com
Mon May 6 21:28:28 CEST 2013


May I suggest that the .const section be used for read-only data instead of
the .text section?
Apple's convention is that the .text section contains pure instructions.

diff --git a/common/x86/x86inc.asm b/common/x86/x86inc.asm
index 7265a0c..18105f5 100644
--- a/common/x86/x86inc.asm
+++ b/common/x86/x86inc.asm
@@ -65,9 +65,9 @@
 ; so use a different read-only section.
 %macro SECTION_RODATA 0-1 16
     %ifidn __OUTPUT_FORMAT__,macho64
-        SECTION .text align=%1
+        SECTION .const align=%1
     %elifidn __OUTPUT_FORMAT__,macho
-        SECTION .text align=%1
+        SECTION .const align=%1
         fakegot:
     %elifidn __OUTPUT_FORMAT__,aout
         section .text
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x264-devel/attachments/20130506/d411b039/attachment.html>


More information about the x264-devel mailing list