[x264-devel] [PATCH] configure: Include dependency libs in the Libs pkg-config line if not building a shared lib

[Martin Storsjö]

On Mon, 22 Jul 2013, Martin Storsjo wrote:

> If only a static library is built, the user of the library that just
> tries to link to the lib using the flags provided by pkg-config
> might not know that only a static lib exists and that he'd have to
> pass --static to pkg-config to get the internal dependencies to
> be able to link the library.
>
> For a shared build, the internal dependencies are kept in Libs.private
> as before.
> ---
> This matches how libav's pkg-config files are generated.
> ---
> configure |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 1df3f0f..b14429a 100755
> --- a/configure
> +++ b/configure
> @@ -1219,8 +1219,8 @@ includedir=$includedir
> Name: x264
> Description: H.264 (MPEG4 AVC) encoder library
> Version: $(grep POINTVER < x264_config.h | sed -e 's/.* "//; s/".*//')
> -Libs: -L$libdir -lx264
> -Libs.private: $libpthread $libm $libdl
> +Libs: -L$libdir -lx264 $([ "$shared" = "yes" ] || echo $libpthread $libm $libdl)
> +Libs.private: $([ "$shared" = "yes" ] && echo $libpthread $libm $libdl)
> Cflags: -I$includedir
> EOF
>
> -- 
> 1.7.9.4

Ping

// Martin