[x264-devel] [PATCH 2/2] Expand silent rules to handle install/uninstall/clean/distclean

[Diego Biurrun]

The same comment about authorship applies.

On Fri, Apr 04, 2014 at 09:41:54AM -0400, Stephen Hutchinson wrote:
> --- a/Makefile
> +++ b/Makefile
> @@ -252,24 +255,38 @@ fprofiled:
>  clean:
> -	rm -f $(OBJS) $(OBJASM) $(OBJCLI) $(OBJSO) $(SONAME) *.a *.lib *.exp *.pdb x264 x264.exe .depend TAGS
> -	rm -f checkasm checkasm.exe $(OBJCHK) $(GENERATED) x264_lookahead.clbin
> -	rm -f $(SRC2:%.c=%.gcda) $(SRC2:%.c=%.gcno) *.dyn pgopti.dpi pgopti.dpi.lock
> +ifeq ($(V), 0)
> +	@printf "Deleting compiled output and files used during compilation...\n";
> +endif

This is silly, there is no need for such messages.

>  distclean: clean
> -	rm -f config.mak x264_config.h config.h config.log x264.pc x264.def
> +ifeq ($(V), 0)
> +	@printf "Deleting configuration files...\n";
> +endif
> +	$(RM) -f config.mak x264_config.h config.h config.log x264.pc x264.def

same

>  install-cli: cli
> +ifeq ($(V), 0)
> +	@printf "INSTALL\t%s\n" x264$(EXE);
> +endif
>  	$(INSTALL) -d $(DESTDIR)$(bindir)
>  	$(INSTALL) x264$(EXE) $(DESTDIR)$(bindir)

All of these look suspiciously like papering over some other issue.

Diego