[x264-devel] [PATCH 1/2] Add autotools-style silent build rules

Diego Biurrun diego at biurrun.de
Tue Apr 15 20:17:41 CEST 2014


So what's the consensus about this feature?  Bugmaster did not seem
exactly thrilled...

On Sat, Apr 05, 2014 at 04:16:51PM -0400, Stephen Hutchinson wrote:
> --- a/Makefile
> +++ b/Makefile
> @@ -2,6 +2,21 @@
>  
>  include config.mak
>  
> +# Silent make rules
> +ifeq ($(V), 0)

The ifndef that Mans used seems slightly cleaner as it would also save
you ..

> --- a/configure
> +++ b/configure
> @@ -279,6 +279,7 @@ bit_depth="8"
>  chroma_format="all"
>  compiler="GNU"
>  opencl="yes"
> +V=0
>  
>  CFLAGS="$CFLAGS -Wall -I. -I\$(SRCPATH)"
>  LDFLAGS="$LDFLAGS"
> @@ -1178,6 +1180,7 @@ PROF_GEN_LD=$PROF_GEN_LD
>  PROF_USE_CC=$PROF_USE_CC
>  PROF_USE_LD=$PROF_USE_LD
>  HAVE_OPENCL=$opencl
> +V=$V
>  EOF

.. setting these.

> @@ -1156,6 +1157,7 @@ includedir=$includedir
>  ARCH=$ARCH
>  SYS=$SYS
>  CC=$CC
> +CC_VERBOSE=$CC
>  CFLAGS=$CFLAGS
>  DEPMM=$DEPMM
>  DEPMT=$DEPMT

Why?

Diego


More information about the x264-devel mailing list