[x264-devel] [PATCH 2/2] More demarcation between install recipes

Diego Biurrun diego at biurrun.de
Tue Apr 15 20:22:27 CEST 2014


On Sat, Apr 05, 2014 at 04:16:52PM -0400, Stephen Hutchinson wrote:
> Separate install recipes that call other recipes from those
> that don't, with the latter doing the actual install work and
> the former tying the latter together.
> 
> Also fixes a cosmetic issue with the silent rules that results
> in missing and incorrect echoing during 'make install'.

This should be done before, not after, the silent build rules IMO.

Right now this patch is a mix of different things, some of which look
correct while others look hacky ...

> --- a/Makefile
> +++ b/Makefile
> @@ -172,7 +172,8 @@ OBJS   += $(SRCS:%.c=%.o)
>  
>  cli: x264$(EXE)

Maybe eliminate this phony target while you're at it?

But possibly people around here like the shortcut ...

> @@ -260,30 +261,41 @@ clean:
>  
> -install-cli: cli
> +install-cli: x264$(EXE)

This was the only other use of the phony target.

Diego


More information about the x264-devel mailing list