[x264-devel] [PATCH 1/2] Add autotools-style silent build rules

[Stephen Hutchinson]

On Tue, Apr 15, 2014 at 2:17 PM, Diego Biurrun <diego at biurrun.de> wrote:
> On Sat, Apr 05, 2014 at 04:16:51PM -0400, Stephen Hutchinson wrote:
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -2,6 +2,21 @@
>>
>>  include config.mak
>>
>> +# Silent make rules
>> +ifeq ($(V), 0)
>
> The ifndef that Mans used seems slightly cleaner as it would also save
> you ..
>

That was mainly to be consistent with autotools' behavior.  Of course,
this would have mattered more in the case of a configure option
that turned off the silencing completely.

>> @@ -1156,6 +1157,7 @@ includedir=$includedir
>>  ARCH=$ARCH
>>  SYS=$SYS
>>  CC=$CC
>> +CC_VERBOSE=$CC
>>  CFLAGS=$CFLAGS
>>  DEPMM=$DEPMM
>>  DEPMT=$DEPMT
>
> Why?
>

The .depend file is generated by a for loop, and this means that it'll
end up printing 'CC .depend' every single time it moves onto a new
file in the loop.  So there'd be a long string of those right at the
beginning, which is unsightly.

Normally the .depend generation is silenced by @, but the silent
rules' eval seems to ignore that (possibly because the loop is
being silenced instead of the individual command?) and latches
onto the CC variable anyway.