[x264-devel] [PATCH 2/2] More demarcation between install recipes

Stephen Hutchinson qyot27 at gmail.com
Wed Apr 16 04:43:18 CEST 2014


On Tue, Apr 15, 2014 at 4:53 PM, Diego Biurrun <diego at biurrun.de> wrote:
> On Sat, Apr 05, 2014 at 04:16:52PM -0400, Stephen Hutchinson wrote:
>> Separate install recipes that call other recipes from those
>> that don't, with the latter doing the actual install work and
>> the former tying the latter together.
>
> After reading this again, I totally don't get what the point of
> this change is.  My suspicion is that something is amiss in the
> other patch and this papers over it.
>

I'm fairly certain it's due to the way the install recipes depend
on other recipes that perform tasks.  I was trying to avoid
messing with the install recipes and fix it in the INSTALL eval,
but nothing actually worked there. It only started working
correctly when I made sure that recipes that do something
don't target other recipes, and instead have the actual
filenames they themselves deal with as their targets.  This
means getting it to work like it should required adding a couple
of new recipes that do nothing but tie together the ones that
perform the tasks.

INSTALL_VERBOSE is there because IIRC, $(Q)$(INSTALL)
wasn't actually silencing those lines, and IMO the directories
don't need to be echoed, only the actual installed files do.

The commit message could definitely be worded better.


More information about the x264-devel mailing list