[x264-devel] [PATCH 5/9] build: Use 'install-static' as a subrecipe for 'install-lib-static'

[Diego Biurrun]

On Sat, Apr 26, 2014 at 05:45:19PM -0400, Stephen Hutchinson wrote:
> 'lib-static' is now used only as the shortcut for default
> ---
>  Makefile | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> --- a/Makefile
> +++ b/Makefile
> @@ -261,8 +261,10 @@ install-lib-pc: x264.pc
>  
> -install-lib-static: lib-static install-lib-dev
> -	$(INSTALL) -m 644 $(LIBX264) $(DESTDIR)$(libdir)
> +install-lib-static: install-lib-dev install-static
> +
> +install-static: $(LIBX264)
> +	$(INSTALL) -m 644 $< $(DESTDIR)$(libdir)
>  	$(if $(RANLIB), $(RANLIB) $(DESTDIR)$(libdir)/$(LIBX264))

I like this in principle, but the log message confuses the heck out of
me.  I'm not sure what the goal is here.  Having a proper prerequisite
instead of a phony one is good, but otherwise the reasons for this
change remain shrouded in mystery.

Also, install-static does not create $(libdir), so it might fail if
invoked directly.

Diego