[x264-devel] [PATCH 5/9] build: Use 'install-static' as a subrecipe for 'install-lib-static'

[Diego Biurrun]

On Mon, Apr 28, 2014 at 11:55:52AM -0400, Stephen Hutchinson wrote:
> On Sun, Apr 27, 2014 at 2:37 PM, Diego Biurrun <diego at biurrun.de> wrote:
> > I like this in principle, but the log message confuses the heck out of
> > me.  I'm not sure what the goal is here.  Having a proper prerequisite
> > instead of a phony one is good, but otherwise the reasons for this
> > change remain shrouded in mystery.
> >
> > Also, install-static does not create $(libdir), so it might fail if
> > invoked directly.
> 
> When configure is run (@lines 1226-1229), it echoes 'lib-static'
> into the default rule in config.mak so that the 'lib-static' shortcut
> builds.  It does similar things for the 'cli' and 'lib-shared' rules
> if they've also been enabled.

Oh gosh, yes, I overlooked this peculiarity of x264's build system.
I haven't read configure properly yet[1], just the Makefile.  I'll reread
this tomorrow, but the $(libdir) bug remains in any case.

Diego

[1] If I read too much, I'll probably want to patch or rewrite it and
time is in short supply currently ...