[x264-devel] arm: move instructions after '.rept' to separate line

Janne Grunau git at videolan.org
Tue Aug 26 18:23:10 CEST 2014


x264 | branch: master | Janne Grunau <janne-x264 at jannau.net> | Sun Jul 20 13:34:27 2014 +0200| [feec4a478bfdfb4426268b2ee79bac473b97488c] | committer: Fiona Glaser

arm: move instructions after '.rept' to separate line

The gas manual states "Repeat the sequence of lines between the .rept
directive and the next .endr directive ...". GNU as seems to support
instructions on the same line as .rept anyway but the integrated
assembler in llvm trunk (to be released 3.5 in August 2014) does not.

> http://git.videolan.org/gitweb.cgi/x264.git/?a=commit;h=feec4a478bfdfb4426268b2ee79bac473b97488c
---

 common/arm/pixel-a.S |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/common/arm/pixel-a.S b/common/arm/pixel-a.S
index 7889d46..e288bcf 100644
--- a/common/arm/pixel-a.S
+++ b/common/arm/pixel-a.S
@@ -28,10 +28,12 @@
 .section .rodata
 .align 4
 
-.rept 16 .byte 0xff
+.rept 16
+        .byte 0xff
 .endr
 mask_ff:
-.rept 16 .byte 0
+.rept 16
+        .byte 0
 .endr
 
 mask_ac4:



More information about the x264-devel mailing list