[x264-devel] [PATCH] Add emulation for previously unsupported XOP fma instructions.

James Almer jamrial at gmail.com
Sun Feb 23 19:50:20 CET 2014


On 23/02/14 3:38 PM, BugMaster wrote:
> On Sat, 22 Feb 2014 23:26:05 -0300, James Almer wrote:
>> Allow non-destructive emulation when the fourth argument
>> is the same as the first by specifying a fifth argument
>> to be used as temporary.
> 
> Hi. IMHO we shouldn't change this in x264 as we don't really use/need
> such non-destructive emulation here (I am not sure were ever will). In
> x264 we only need to warn about use of non-supported variants of args.
> Why don't you simply add this non-destructive macroses into ffmpeg's
> x86util.asm (as I understand ffmpeg was the initial reason why you
> wrote this patch) which is anyway not in sync with x264's one (so no
> need port them to x264)?

Someone suggested i could submit this here as well, so i did as much.

There are afaik also other projects that pull x86inc/util changes from 
upstream (aka, x264) that might benefit from a complete emulation of 
XOP instruction, but yes, i agree it's not (currently) useful for x264.


More information about the x264-devel mailing list