[x264-devel] install_name wrong on macosx builds?

[Dan Kegel]

When building libraries for MacOSX, one has to either get the
-install_name option
right when building, or run install_name_tool -id to tell the library its final
install location.  Otherwise libraries or binaries linked against it will fail
to load.

Currently, x264 uses DESTDIR in the -install_name option.  This may
be good for allowing testing without installation, but I don't see a
"make check" target.

I have two workarounds.  The first is to run the command

   install_name_tool -id $PREFIX/lib/libx264.138.dylib
$DESTDIR$PREFIX/lib/libx264.138.dylib

manually after building the library.   A nicer one is the attached patch,
which gives the library the 'right' install_name from the start, and adds
padding in case anyone needs to change it later.
- Dan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: x264-final-install-name.patch
Type: text/x-patch
Size: 767 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/x264-devel/attachments/20140129/05abeda8/attachment.bin>