[x264-devel] [PATCH 1/8] arm: do not append CFLAGS to ASFLAGS

[Diego Biurrun]

On 2014-07-20 18:48, Janne Grunau wrote:
> --- a/configure
> +++ b/configure
> @@ -296,7 +296,7 @@ opencl="yes"
>   CFLAGS="$CFLAGS -Wall -I. -I\$(SRCPATH)"
>   LDFLAGS="$LDFLAGS"
>   LDFLAGSCLI="$LDFLAGSCLI"
> -ASFLAGS="$ASFLAGS"
> +ASFLAGS="$ASFLAGS -I. -I\$(SRCPATH)"
>   RCFLAGS="$RCFLAGS"
>   HAVE_GETOPT_LONG=1
>   cross_prefix=""
> @@ -752,7 +752,7 @@ if [ $asm = auto -a $ARCH = ARM ] ; then
>       if  cc_check '' '' '__asm__("rev ip, ip");' ; then      define HAVE_ARMV6
>           cc_check '' '' '__asm__("movt r0, #0");'         && define HAVE_ARMV6T2
>           cc_check '' '' '__asm__("vadd.i16 q0, q0, q0");' && define HAVE_NEON
> -        ASFLAGS="$ASFLAGS $CFLAGS -c"
> +        ASFLAGS="$ASFLAGS -c"

An alternative would be to add a CPPFLAGS variable.

LGTM as-is.

Diego